Skip to content

#332 rounding down of passed percentage #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
Merged

Conversation

ed-snodgrass
Copy link
Contributor

πŸ€” What's changed?

The code was modified to round down rather than round up and to allow 1 decimal place

⚑️ What's your motivation?

Fixes #332

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

I would like to know if folks think it should still only display round numbers and/or if it should only round down when between 99% and 100%

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

…ounding down and display of 1 decimal place
Copy link

netlify bot commented Apr 23, 2025

βœ… Deploy Preview for cucumber-react-preview ready!

Name Link
πŸ”¨ Latest commit 871a9c8
πŸ” Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/680a59799adea70008f38f34
😎 Deploy Preview https://deploy-preview-380--cucumber-react-preview.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @ed-snodgrass. To your questions:

I would like to know if folks think it should still only display round numbers

I think a single decimal place would be a good balance if you're up for changing that too.

and/or if it should only round down when between 99% and 100%

I think, especially when combined with 1 dp per above, always flooring will be fine.

@ed-snodgrass
Copy link
Contributor Author

ed-snodgrass commented Apr 24, 2025

I agree with one dp. I initially had it that way and then went back to round numbers just in case. I'll move that back to one.

@davidjgoss davidjgoss merged commit 9b3f277 into cucumber:main Apr 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Percentage of tests passed is rounded up
2 participants