Skip to content

Don't set font-size, use ems consistently #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Don't set font-size, use ems consistently #377

merged 2 commits into from
Apr 7, 2025

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Apr 7, 2025

🤔 What's changed?

Previously, the library included a font-size: 14px that was overly opinionated and resulted in smaller type than generally looks good in most contexts. This PR removes that setting and ensures that font-size declarations elsewhere are consistently in em units. This means we'll inherit the nearest declared parent font-size, or otherwise just the root font-size which is 16px by default. Also, headings for Gherkin keywords have been adjusted so they work well at that default size.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 35ddb95
🔍 Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/67f37f70e8f19d0008e48dde
😎 Deploy Preview https://deploy-preview-377--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidjgoss davidjgoss changed the title dont set font-size, use ems consistently Don't set font-size, use ems consistently Apr 7, 2025
@davidjgoss davidjgoss marked this pull request as ready for review April 7, 2025 07:34
@davidjgoss davidjgoss merged commit d06afe5 into main Apr 7, 2025
6 checks passed
@davidjgoss davidjgoss deleted the font-size branch April 7, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant