Remove EnvelopesQuery, use hooks over props for app components #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR makes some changes to the library to simplify things for consuming apps, and simplify some internals too.
EnvelopesQuery
class since recent additions to@cucumber/query
give us what we need for those use cases. A couple of other helpers are also defunct and duly removed for the same reason.<StatusesSummary/>
,<ExecutionSummary/>
,<SearchBar/>
) together to make the kind of report you want - it required a lot of orchestration and understanding to pass the required props to each component and interact with the right bits of context. Now those components are prop-free, using hooks internally to get and set the state they need, and theFilteredResults
component is now an exercise in straightforward composition. This isn't the trade off we'd always make for e.g. a general purpose component library, but here it makes sense to bake in the assumption that you're working within an<EnvelopesWrapper/>
context and reap the DX benefits.Since many of the changed components were exported, this is a breaking change.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.