Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support text/uri-list attachments #355

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Support text/uri-list attachments #355

merged 8 commits into from
Aug 2, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jul 29, 2024

🤔 What's changed?

Special support for attachments with MIME type text/uri-list, to render as hyperlinks that open in a new tab.

image

⚡️ What's your motivation?

See cucumber/common#2191

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for cucumber-react-components ready!

Name Link
🔨 Latest commit dd60ea2
🔍 Latest deploy log https://app.netlify.com/sites/cucumber-react-components/deploys/66aceffa199cd200080e486c
😎 Deploy Preview https://deploy-preview-355--cucumber-react-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you document all the supported media types in the readme? Otherwise this feature stays quite hidden.

@davidjgoss
Copy link
Contributor Author

Can you document all the supported media types in the readme?

Good point, done.

@mpkorstanje mpkorstanje merged commit 7c14692 into main Aug 2, 2024
6 checks passed
@mpkorstanje mpkorstanje deleted the feat/uri-attachments branch August 2, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants