-
Notifications
You must be signed in to change notification settings - Fork 12
feat: support TestStepResult.exception #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cucumber-react-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in a backwards-compatible way to allow content as children
instead of a string prop - we need this to use in our new component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This edits are due to upstream changes in the CCK sources.
The "with stacktrace" step fails in the preview with;
|
@mpkorstanje thats the actual presentation, not an error when trying to render. |
Might need some support here as this now means the ruby side renders a shorter message than previously before. All stacktrace data is now missing Will chat to you later about this @davidjgoss |
With cucumber/react-components#345 the html formatter started to support rendering stack traces. Unfortunately this also broke the regular rendering of stacktrace. And fixing this required including the stack trace the xml report as well so that when the Convertor in messages was fixed to always include the stacktrace, we wouldn't render the stacktrace in the xml formatter twice.
With cucumber/react-components#345 the html formatter started to support rendering stack traces. Unfortunately this also broke the regular rendering of stacktrace. And fixing this required including the stack trace the xml report as well so that when the Convertor in messages was fixed to always include the stacktrace, we wouldn't render the stacktrace in the xml formatter twice.
With cucumber/react-components#345 the html formatter started to support rendering stack traces. Unfortunately this also broke the regular rendering of stacktrace. And fixing this required including the stack trace the xml report as well so that when the Convertor in messages was fixed to always include the stacktrace, we wouldn't render the stacktrace in the xml formatter twice.
🤔 What's changed?
This PR adds support in the components for an
exception
object within theTestStepResult
. This is designed to give more structured information about a problem than the flat stringmessage
field. We'll now use the exception (and disregard the old message field) if present.⚡️ What's your motivation?
Make use of the structured exception object for Cucumber implementations that support it, whilst maintaining backwards-compatibility with those that don't yet.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.