Skip to content

upgrade to react 18, storybook -> ladle #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Nov 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1aa90c5
install react 18 and update peer deps
davidjgoss Aug 26, 2022
14f91bf
more dependency changes
davidjgoss Aug 26, 2022
6e366c0
fix compilation due to FunctionComponent changes
davidjgoss Aug 26, 2022
85eaeb4
make test interactions async
davidjgoss Aug 26, 2022
0456963
fix test providers
davidjgoss Aug 26, 2022
2ba22e6
build storybook as part of pr workflow
davidjgoss Aug 26, 2022
d930f71
remove storybook
davidjgoss Aug 26, 2022
6ec9147
add ladle
davidjgoss Aug 27, 2022
20d2b65
add vite config to get around lunr issue
davidjgoss Aug 27, 2022
911dfe6
add ladle build to pr workflow
davidjgoss Aug 27, 2022
3aaedd9
update stories to use ladle imports
davidjgoss Aug 27, 2022
4386aeb
remove atob workaround
davidjgoss Aug 27, 2022
e02be1d
remove redundant story
davidjgoss Aug 27, 2022
8aebb3e
move stories inline with components
davidjgoss Aug 27, 2022
bab2bb1
update readme
davidjgoss Aug 27, 2022
615d7d7
merge main
davidjgoss Nov 6, 2022
8734ca3
fix dependencies from bad merge
davidjgoss Nov 6, 2022
70dc330
bump ladle version
davidjgoss Nov 6, 2022
93f46e5
Merge branch 'main' into react-18
davidjgoss Nov 8, 2022
c1d5449
dont run ladle build for now
davidjgoss Nov 9, 2022
0f04bc9
merge main
davidjgoss Nov 9, 2022
49e6f9a
fix lockfile
davidjgoss Nov 9, 2022
7002dbf
fix typescript issues
davidjgoss Nov 9, 2022
9b97299
fix lint
davidjgoss Nov 9, 2022
3b4057e
merge main
davidjgoss Nov 10, 2022
2bd5d40
Update README.md
davidjgoss Nov 10, 2022
513b843
Update CHANGELOG.md
davidjgoss Nov 10, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,5 @@ jobs:
- run: npm test
- run: npm run eslint
- run: npm run compile
# not running ladle build due to elasticlunr bundling issue
# - run: npm run build
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
acceptance/
build/
dist/
.idea/
node_modules/
*.log
.codegen
acceptance/
storybook-static
*.iml
.vscode-test
32 changes: 0 additions & 32 deletions .storybook/main.js

This file was deleted.

4 changes: 0 additions & 4 deletions .storybook/preview.js

This file was deleted.

2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]
### Changed
- BREAKING CHANGE: React 18+ is now required ([#279](https://github.com/cucumber/react-components/pull/279))

## [20.2.0] - 2022-09-13
### Changed
Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

## Usage

React 18 or above is required.

The source code for screenshots above is:

```jsx
Expand Down Expand Up @@ -152,7 +154,7 @@ Run tests

Interactive development

npm run storybook
npm start

## Ideas

Expand Down
Loading