Skip to content

upgrade react-components to 21.1.1 #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jul 13, 2023

⚡️ What's your motivation?

To bring in latest improvements around attachment handling.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@olleolleolle
Copy link
Contributor

Huh, some kind of webpack/default node polyfills breakage.

@davidjgoss
Copy link
Contributor Author

Yeah looks like mime-types is not browser-compatible, was being masked by polyfills from Ladle.

cucumber/react-components#334

@davidjgoss davidjgoss changed the title upgrade react-components to 21.1.0 upgrade react-components to 21.1.1 Jul 13, 2023
@davidjgoss davidjgoss merged commit 0ba83e3 into main Jul 13, 2023
@davidjgoss davidjgoss deleted the feat/attachments-improvements branch July 13, 2023 15:09
@olleolleolle
Copy link
Contributor

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants