Skip to content

java: Deprecate GherkinDialectProvider in favour of GherkinDialects #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpkorstanje merged 5 commits into from
Jul 30, 2025
Merged

java: Deprecate GherkinDialectProvider in favour of GherkinDialects #448

mpkorstanje merged 5 commits into from
Jul 30, 2025

Conversation

@mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jul 30, 2025 •
edited
Loading

🤔 What's changed?

  • Deprecate GherkinDialectProvider in favour of GherkinDialects
  • Remove redundant Gherkin prefix from package private classes
  • Remove unused GherkinException
  • Replace Step type conversion to pickle step type conversion with switch statement

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje
java: Refactor and rename
b3bbdc1 
- Deprecate `GherkinDialectProvider` in favour of `GherkinDialects`
- Remove redundant `Gherkin` prefix from package private classes
- Remove unused `GherkinException`
- Replace Step type conversion to pickle step type conversion with
  switch statement
@mpkorstanje
Update CHANGELOG
3b2f34b
@mpkorstanje mpkorstanje changed the title java: Refactor and rename java: Deprecate GherkinDialectProvider in favour of GherkinDialects Jul 30, 2025
@mpkorstanje mpkorstanje merged commit 3a0b21a into main Jul 30, 2025
4 checks passed
@mpkorstanje mpkorstanje deleted the java-refactor-and-rename branch July 30, 2025 16:27
This was referenced Aug 18, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Sep 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mpkorstanje