Fix Configuration.with_options merge direction #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSP-13453 Shows that with_options test only passed becasue out_stream hadn't been set on the Configuration before calling with_options(out_stream:).
MSP-13453 Must be old.merge(new) so that new values for keys in both old and new win. Without this change, `factory.new(@configuration.with_options(out_stream: out_stream))` in Cucumber::Runtime#create_formatter doesn't actually changed the out_stream from STDOUT in the default configuration.
|
SUPERSLEUTH! 🔍 Thanks Luke, great work. |
mattwynne
added a commit
that referenced
this pull request
Oct 13, 2015
…rection Fix Configuration.with_options merge direction
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change,
factory.new(@configuration.with_options(out_stream: out_stream))in Cucumber::Runtime#create_formatter doesn't actually changed theout_streamfrom STDOUT in the default configuration because the merge order wasnew_options.merge(@options), so any keys in bothnew_optionsand@options, like:out_stream, would have the value from@optionswin.The specs weren't catching this problem because
with_optionswas being called onConfiguration.new, which had no keys set. I changed in spec in 63d4c37 to reveal the bug and fixed it in 067215c.This bug may have manifested by users unable to override the --out from STDOUT when using new formatters that have
initialize(configuration)instead of the legacyinitialize/3