Feature: Support of relative image sources #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an File-based image is not placed correctly, embedding the image will fail. This sanity check creates a relative path to the HTML IO object. Pre-conditions: - The image to be embedded must be file based - The html IO object must be support an absolute_path method (http://www.ruby-doc.org/core-2.1.2/File.html#method-c-absolute_path)
|
@brasmusson any comments? Can you merge this if you like it please. |
brasmusson
added a commit
that referenced
this pull request
Dec 28, 2014
|
I do not know in what Ruby versions an open file object responds to an |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an File-based image is not placed correctly, embedding the image will fail. This sanity check creates a relative path to the HTML IO object.
Pre-conditions: