Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 2.6 support #1699

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

kupolak
Copy link
Member

@kupolak kupolak commented Mar 4, 2023

Description

Drop support for Ruby 2.6. Adresses #1693

Type of change

  • Reducing technical debt

Please add an entry to the relevant section of CHANGELOG.md as part of this pull request. - Done ✔️

Note to other contributors

This PR might fix the red build here: #1689

Update required of cucumber.io/docs

Changes are not required in cucumber.io/docs

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code - not needed
  • New and existing tests are passing locally and on CI - tested locally, i was not able to trigger the CI. But it should work, we are only removing the language version from matrix
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated - not needed
  • CHANGELOG.md has been updated

@kupolak kupolak force-pushed the drop-ruby-2.6-support branch 3 times, most recently from b8e4b1d to 813d387 Compare March 4, 2023 13:08
@kupolak kupolak marked this pull request as ready for review March 4, 2023 13:37
@olleolleolle
Copy link
Contributor

@kupolak Minor: Will we need to re-run RuboCop after re-configuring it to target 2.7?

@olleolleolle
Copy link
Contributor

One thing:

  • JRuby 9.3.x is compatible with Ruby 2.6.x - and if we are removing 2.6, it ought to be replaced with jruby-9.4

@luke-hill
Copy link
Contributor

I'm happy for the change to jruby in the target matrix as specified by Olle.

@kupolak if you make that change and get CI green I'll approve and merge this.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from here!

@luke-hill luke-hill merged commit 3db0a1b into cucumber:main Mar 13, 2023
@aslakhellesoy
Copy link
Contributor

Hi @kupolak,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants