-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency to cucumber-wire #1562
Conversation
cucumber/cucumber-ruby-wire#46 is the cucumber-ruby-wire counter-part of this PR. Everything seems to be ok actually, we would just need a deprecation/release plan for this but technically, it seems to be all good |
We are ready to remove it now 😀 |
The wire protocol is not a direct dependency anymore, so it is not as important as before while contributing.
It is not a direct dependency anymore.
I am ready to merge that one if no further objection @mattwynne @luke-hill? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typos. Other than that RtM
Description
cucumber-ruby-wire
has been design to be an external optional dependency. This is not the case yet and it is responsible for adding complexity in the dependency tree for cucumber-ruby.This PR aims to remove the dependency to
cucumber-ruby-wire
. The wire protocol would still be available but requiring it explicitly.Type of change
work as expected)
Note to other contributors
Tests may be passing but there are a lot of things to do before merging this PR. We will certainly have to deprecate it first in a new major version before removing it completely in another new one.
For now what remains to be done here is to add a hook for
cucumber-ruby-wire
to be able to install by itself.Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocop
reports no offenses