Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metrics/LineLength - PARTIAL - 01 #1174

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Fix Metrics/LineLength - PARTIAL - 01 #1174

merged 1 commit into from
Aug 22, 2017

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Aug 10, 2017

Summary

Partially Fixing Metrics/LineLength

Details

  • Changes to line length 80. If 100 is desired, let me know!
  • Only fixed examples directory to keep change down.
  • Most of the change in this PR happened at the beginning of files that load rspec and spec expectations.

Motivation and Context

Working to help solve issue 1021!

How Has This Been Tested?

bundle exec rake 👍

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mxygem
Fix Metrics/LineLength - PARTIAL - #1
ef28877 
* Fixed only the examples/ directory to keep things from getting out of hand.
@mxygem mxygem changed the title Fix Metrics/LineLength - PARTIAL - #01 Fix Metrics/LineLength - PARTIAL - 01 Aug 10, 2017
olleolleolle
olleolleolle approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite clear.

Thank you for your hard work on changing this.

@mxygem
Copy link
Member Author

mxygem commented Aug 22, 2017

Thanks bud!

@mxygem mxygem merged commit e0a704f into cucumber:master Aug 22, 2017
@mxygem mxygem deleted the 1021-fix-style-violations-4 branch August 22, 2017 12:31
@mxygem
Copy link
Member Author

mxygem commented Aug 22, 2017

History file has been updated on master

@brasmusson brasmusson mentioned this pull request Aug 22, 2017
Closed
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxygem @olleolleolle