Merge pull request #1555 from cucumber/environment-variables-link

Point to https://cucumber.io/docs/cucumber/environment-variables/
cucumber · Jun 22, 2021 · 68cd3ae · 68cd3ae
2 parents 67a502a + f271f70
commit 68cd3ae
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 27 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
   ([1546](https://github.com/cucumber/cucumber-ruby/issues/1546)
   [1548](https://github.com/cucumber/cucumber-ruby/pull/1548)
   [Serghei Moret](https://github.com/JoeSSS))
+- Fixed reports banner to point to [new docs](https://cucumber.io/docs/cucumber/environment-variables/) about environment variables
 
 ### Changed
 

diff --git a/features/docs/cli/publish_banner.feature b/features/docs/cli/publish_banner.feature
@@ -11,19 +11,19 @@ Feature: Publish banner
     When I run `cucumber`
     Then the output should contain:
     """
-    ┌──────────────────────────────────────────────────────────────────────────┐
-    │ Share your Cucumber Report with your team at https://reports.cucumber.io │
-    │                                                                          │
-    │ Command line option:    --publish                                        │
-    │ Environment variable:   CUCUMBER_PUBLISH_ENABLED=true                    │
-    │ cucumber.yml:           default: --publish                               │
-    │                                                                          │
-    │ More information at https://reports.cucumber.io/docs/cucumber-ruby       │
-    │                                                                          │
-    │ To disable this message, specify CUCUMBER_PUBLISH_QUIET=true or use the  │
-    │ --publish-quiet option. You can also add this to your cucumber.yml:      │
-    │ default: --publish-quiet                                                 │
-    └──────────────────────────────────────────────────────────────────────────┘
+    ┌──────────────────────────────────────────────────────────────────────────────┐
+    │ Share your Cucumber Report with your team at https://reports.cucumber.io     │
+    │                                                                              │
+    │ Command line option:    --publish                                            │
+    │ Environment variable:   CUCUMBER_PUBLISH_ENABLED=true                        │
+    │ cucumber.yml:           default: --publish                                   │
+    │                                                                              │
+    │ More information at https://cucumber.io/docs/cucumber/environment-variables/ │
+    │                                                                              │
+    │ To disable this message, specify CUCUMBER_PUBLISH_QUIET=true or use the      │
+    │ --publish-quiet option. You can also add this to your cucumber.yml:          │
+    │ default: --publish-quiet                                                     │
+    └──────────────────────────────────────────────────────────────────────────────┘
     """
 
   Scenario: Banner is not displayed when using --publish-quiet

diff --git a/lib/cucumber/formatter/publish_banner_printer.rb b/lib/cucumber/formatter/publish_banner_printer.rb
@@ -41,7 +41,7 @@ def display_publish_ad(io)
             '',
             [
               'More information at ',
-              link('https://reports.cucumber.io/docs/cucumber-ruby')
+              link('https://cucumber.io/docs/cucumber/environment-variables/')
             ],
             '',
             [

diff --git a/spec/cucumber/formatter/publish_banner_printer_spec.rb b/spec/cucumber/formatter/publish_banner_printer_spec.rb
@@ -24,19 +24,19 @@ module Formatter
         it 'prints banner' do
           run_defined_feature
           expect(@err.string).to include(<<~BANNER)
-            ┌──────────────────────────────────────────────────────────────────────────┐
-            │ Share your Cucumber Report with your team at https://reports.cucumber.io │
-            │                                                                          │
-            │ Command line option:    --publish                                        │
-            │ Environment variable:   CUCUMBER_PUBLISH_ENABLED=true                    │
-            │ cucumber.yml:           default: --publish                               │
-            │                                                                          │
-            │ More information at https://reports.cucumber.io/docs/cucumber-ruby       │
-            │                                                                          │
-            │ To disable this message, specify CUCUMBER_PUBLISH_QUIET=true or use the  │
-            │ --publish-quiet option. You can also add this to your cucumber.yml:      │
-            │ default: --publish-quiet                                                 │
-            └──────────────────────────────────────────────────────────────────────────┘
+            ┌──────────────────────────────────────────────────────────────────────────────┐
+            │ Share your Cucumber Report with your team at https://reports.cucumber.io     │
+            │                                                                              │
+            │ Command line option:    --publish                                            │
+            │ Environment variable:   CUCUMBER_PUBLISH_ENABLED=true                        │
+            │ cucumber.yml:           default: --publish                                   │
+            │                                                                              │
+            │ More information at https://cucumber.io/docs/cucumber/environment-variables/ │
+            │                                                                              │
+            │ To disable this message, specify CUCUMBER_PUBLISH_QUIET=true or use the      │
+            │ --publish-quiet option. You can also add this to your cucumber.yml:          │
+            │ default: --publish-quiet                                                     │
+            └──────────────────────────────────────────────────────────────────────────────┘
           BANNER
         end
       end