Skip to content

[Weld] Document the need for a beans.xml per source root #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

albers
Copy link
Member

@albers albers commented Oct 16, 2015

For injecting classes from src/main/java into glue code in src/test/java, two beans.xml files are required.
This is not trivial and should be documented in order to avoid confusion.

This PR adds documentation about where to place the beans.xml for selected injection scenarios.

Signed-off-by: Harald Albers <github@albersweb.de>
@mlvandijk mlvandijk added the 📖 documentation Improvements or additions to documentation label Sep 1, 2017
@mpkorstanje mpkorstanje force-pushed the master branch 9 times, most recently from 159ec4c to 74325ea Compare December 10, 2017 20:05
@stale
Copy link

stale bot commented Feb 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 12, 2018
@albers
Copy link
Member Author

albers commented Feb 12, 2018

Just to pruduce some activity so that this issue won't be closed.

@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Feb 12, 2018
@stale
Copy link

stale bot commented Apr 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Apr 13, 2018
@albers
Copy link
Member Author

albers commented Apr 13, 2018

Just to pruduce some activity so that this issue won't be closed.

@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Apr 13, 2018
@mpkorstanje mpkorstanje changed the title Document the need for two beans.xml for injection from /src/main/java [Weld] Document the need for two beans.xml for injection from /src/main/java Jun 16, 2018
@mpkorstanje mpkorstanje changed the title [Weld] Document the need for two beans.xml for injection from /src/main/java [Weld] Document the need for a beans.xml per source root Jun 16, 2018
@aslakhellesoy
Copy link
Contributor

Hi @albers,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje mpkorstanje merged commit 00e1dab into cucumber:master Jun 16, 2018
@mpkorstanje
Copy link
Contributor

@albers I realize this is almost 3 years over due this was a useful contribution!

@mpkorstanje mpkorstanje added this to the 4.0.0 milestone Jun 16, 2018
@albers albers deleted the cucumber-weld-doc branch June 16, 2018 21:24
@albers
Copy link
Member Author

albers commented Jun 16, 2018

@aslakhellesoy Thanks very much for adding me to the organisation. I appreciate this very much. I use Cucumber frequently, so being involved really makes sense to me.

@aslakhellesoy
Copy link
Contributor

Glad to have you on board @albers!

@mlvandijk
Copy link
Member

Hello @albers, please consider joining us on Slack and/or the mailing list (if you haven't already). You can find more info here: https://cucumber.io/support

@lock
Copy link

lock bot commented Jun 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants