Fix stop watch thread safety

[davebassan]

Running the cucumber tests in parallel results in a NullPointerException being thrown by the StopWatch stop method as it is not thread safe.

I added a test to replicate the issue and have updated the StopWatch class to be thread safe.

[aslakhellesoy]

LGTM - @brasmusson can you merge this one in please?

[brasmusson]

I'll take care of it.

[brasmusson]

Merged. Thanks for your effort @davebassan

[ffbit]

May be the start.remove() is more appropriate.

[RobinAllen]

I'm hitting (I believe) this same issue running parallel tests in junit+cucumber-spring.

java.lang.NullPointerException
at cucumber.runtime.StopWatch$1.stop(StopWatch.java:21)
at cucumber.runtime.Runtime.runStep(Runtime.java:296)
at cucumber.runtime.model.StepContainer.runStep(StepContainer.java:44)
at cucumber.runtime.model.StepContainer.runSteps(StepContainer.java:39)
at cucumber.runtime.model.CucumberScenario.runBackground(CucumberScenario.java:49)
at cucumber.runtime.model.CucumberScenario.run(CucumberScenario.java:38)
at cucumber.runtime.junit.ExecutionUnitRunner.run(ExecutionUnitRunner.java:83)
at cucumber.runtime.junit.FeatureRunner.runChild(FeatureRunner.java:63)
at cucumber.runtime.junit.FeatureRunner.runChild(FeatureRunner.java:18)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at cucumber.runtime.junit.FeatureRunner.run(FeatureRunner.java:70)
at cucumber.api.junit.Cucumber.runChild(Cucumber.java:82)
at cucumber.api.junit.Cucumber.runChild(Cucumber.java:41)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:258)
at ...

I'm just wondering if/when the fix likely to make it into a future release?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.