[All] Remove Jackson from cucumber-jvm parent pom
#1900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `cucumber-jvm` parent pom included `jackson-databind` in its dependency management section. Because this is a test only dependency it was marked as test scoped. While not intended to function as a bill of materials people were and perhaps still are using `cucumber-jvm` in this fashion. Removing `jackson-databind` from the dependency management ensures that `cucumber-jvm` only manages cucumber and test related dependencies.
timtebeek
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cucumber-jvmparent pom includedjackson-databindin its dependencymanagement section. Because this is a test only dependency it was marked as
test scoped.
While not intended to function as a bill of materials people were and perhaps
still are using
cucumber-jvmin this fashion. Removingjackson-databindfrom the dependency management ensures that
cucumber-jvmonly managescucumber and test related dependencies.
While not safe, this does provide a modicum of safety.
Types of changes