[Core] Merge cucumber-html into cucumber-core #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
reviewed
Jun 4, 2019
| @@ -14,9 +14,10 @@ target/ | |||
| tmp/ | |||
| gen-external-apklibs/ | |||
| out/ | |||
| some/ | |||
There was a problem hiding this comment.
We should really figure out who creates this directory.
There was a problem hiding this comment.
HTMLFormatterTest is the culprit.
There was a problem hiding this comment.
I'll make a seperate PR to fix that.
mpkorstanje
approved these changes
Jun 4, 2019
mpkorstanje
changed the title
mpkorstanje
reviewed
Jun 4, 2019
.gitignore
Outdated
|
|
||
| # Build & test droppings | ||
| report.js | ||
| # report.js |
There was a problem hiding this comment.
Suggested change
| # report.js |
mpkorstanje
reviewed
Jun 4, 2019
| @@ -14,9 +14,10 @@ target/ | |||
| tmp/ | |||
| gen-external-apklibs/ | |||
| out/ | |||
| some/ | |||
|
@grasshopper7 could you rebase your branch on master? I've made sure that the tests will write their files to the |
|
Owh cool I can do that online too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Copied HtmlFormatter resources from cucumber-html to cucumber-core.
Fixes: #1647
Details
Motivation and Context
Refer issue
How Has This Been Tested?
Passes existing test in HTMLFormatterTest, no additional functionality added.
Types of changes
Checklist: