Skip to content

[Core] Use all generated snippets #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2018
Merged

[Core] Use all generated snippets #1443

merged 1 commit into from
Aug 28, 2018

Conversation

mpkorstanje
Copy link
Contributor

Summary

Use all generated snippets

Fixes #1433

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mpkorstanje mpkorstanje added this to the 4.0.0 milestone Aug 28, 2018
@mpkorstanje mpkorstanje merged commit 6126dc4 into master Aug 28, 2018
@mpkorstanje mpkorstanje deleted the use-all-generated-snippets branch August 28, 2018 18:36
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 85.588% when pulling 38bca82 on use-all-generated-snippets into 153ecb7 on master.

@lock
Copy link

lock bot commented Aug 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Only a single snippet is generated when multiple parameter types match
2 participants
@mpkorstanje @coveralls