fix(cli): Remove UTF Bye Order Mark #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves the exception produced parsing .feature files created on Visual Studio with a BOM (Byte Order Mark) initial character. As seen on node-jshint: ArturDorochowicz/node-jshint@b36ac70
|
Brilliant! There is an open bug for this in the gherkin lib (with a disabled failing test IIRC). Can you submit a fix there instead please? Thanks! |
|
Ok, thanks @aslakhellesoy. I'm seeing that's an old issue that has not been solved yet on the gherkin parser, sorry for not reading before. :( I will notify the issue there, and try to make a patch. |
|
Is this PR still relevant? |
|
No, the fix should be done in gherkin |
|
Hi, this PR can be closed. I have sent a similar PR to gherkin which tries to solve this issue here: cucumber/gherkin#301. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the exception produced parsing .feature files created on Visual Studio
with a BOM (Byte Order Mark) initial character.
As seen on node-jshint:
ArturDorochowicz/node-jshint@b36ac70