Remove redundant steps in attachment feature #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgoss
requested changes
May 17, 2025
|
How are these steps definitions redundant? The steps are still there: compatibility-kit/devkit/samples/attachments/attachments.feature Lines 33 to 37 in 21ee438 |
|
Sorry yeh this was just a "make this now so I don't forget". I need to do more work here. Spotted this whilst doing my v10 work |
|
No problem. I've marked the PR as a draft. |
luke-hill
force-pushed
the
luke-hill-patch-1
branch
from
21ee438 to
5416ff8
Compare
mpkorstanje
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Removed duplicate step/scenario from attachments and done some minor tidying
⚡️ What's your motivation?
🏷️ What kind of change is this?
Breaking change: Next version v19
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.