Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber-expressions: Fixed broken link to cucumber expression docs #484

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

Izhaki
Copy link
Contributor

@Izhaki Izhaki commented Sep 28, 2018

No description provided.

@aslakhellesoy aslakhellesoy merged commit 19855fd into cucumber:master Sep 28, 2018
@aslakhellesoy
Copy link
Contributor

Hi @Izhaki,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@Izhaki
Copy link
Contributor Author

Izhaki commented Dec 23, 2018

@aslakhellesoy Security matter!

Having made a tiny contribution to Cucumber, I now have very privileged rights! This is cool - saves me the need to fork...

But I just wonder if this is tight enough? This has been huge recently:

indexzero/ps-tree#33

And we don't have publishing right alright, but just wonder if it there is a mechanism in place for things not to be merged to master without some authority approving them?

Thanks

@Izhaki Izhaki deleted the patch-1 branch December 23, 2018 23:12
@lock
Copy link

lock bot commented Dec 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants