Add --tag-format option to the release command #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslakhellesoy
changed the title
aslakhellesoy
added a commit
to cucumber/.github
that referenced
this pull request
Nov 9, 2021
See cucumber/changelog#2 for details.
aurelien-reeves
left a comment
aurelien-reeves
left a comment
There was a problem hiding this comment.
Despite the goreleaser failed action, the changes looks good to me
mattwynne
approved these changes
Nov 9, 2021
|
@mattwynne you merged these PR despite the failed CI. Is the goreleaser job expected to fail? If so, can we remove it or, better, fix it to make it pass? |
Author
|
Yes, goreleaser is expected to fail and unrelated to this change. We'll fix that in a separate PR. For now, users have to build and install the binary on their own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects use a
vprefix in front of tags, as illustrated by the older tags in this changelog.The KAC spec does not mandate a particular format for git tags, but the example in the spec uses a
vprefix. It seems we should allow some flexibility around this, to cater for different practices.This PR adds a new
--tag-formatoption where the user can specify a printf format (for examplev%s).This should allow us to create correct links in the bottom of the changelog.