Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core cucumber event bus implementation #930

Merged
merged 3 commits into from
May 31, 2024
Merged

Use core cucumber event bus implementation #930

merged 3 commits into from
May 31, 2024

Conversation

mvz
Copy link
Contributor

@mvz mvz commented May 31, 2024

Summary

Replace Aruba's own EventBus implementation with the one from cucumber-core. A few extra methods are provided for compatibility with current use of the event bus.

Details

  • Only support symbols to specify events
  • Base Aruba event bus on the core Cucumber event bus
  • Remove obsolete Aruba::EventBus::NameResolver

Motivation and Context

The existing implementation, in particular the resolver, seemed overly complex for how it was used. The core implementation is simpler and using it instead of our own reduces duplication.

How Has This Been Tested?

Specs were run.

Types of changes

  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

@mvz mvz merged commit 356c7d7 into main May 31, 2024
18 checks passed
@mvz mvz deleted the core-event-bus branch May 31, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant