Make #have_output_size work on a process #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces grouping and sets up the string object only once.
This allows use of the matcher without first calling #output on the process. A possible improvement would be the option of specifying which output should be matched (stderr, stdout, both).
Users of this matcher should switch to applying it to a process object, or test the length of the string directly.
The use of #have_output_size with strings is deprecated.
mvz
force-pushed
the
improve-have-output-size-matcher
branch
from
12e9aa7
to
561b141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
#have_output_sizematcher work with process objects, and deprecate its use with strings.Details
#have_output_size matcher#have_output_sizematcher work with process objects#have_output_sizematcher with process object in supplied stepMotivation and Context
Fixes #484.
How Has This Been Tested?
I ran the relevant specs and cukes.
Types of changes
Checklist: