Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cucumber version 9.0 #904

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Support cucumber version 9.0 #904

merged 1 commit into from
Sep 1, 2023

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Sep 1, 2023

Summary

Update dependencies to support Cucumber 9.0

Details

  • Update cucumber dependency to allow version 9.0
  • Add appraisal to test with cucumber 9.0
  • Add cucumber 9.0 to the CI matrix

Motivation and Context

Cucumber 9.0 was released and Aruba should support it.

How Has This Been Tested?

I ran ran the test suite in the relevant appraisal. There was a failing cucumber scenario due to a change in bundle --local's output. That will have to be addressed in another pull request, but hopefully it will not be a problem in CI. This was fixed in #905.

Types of changes

  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz mvz force-pushed the support-cucumber-9 branch 2 times, most recently from ea8add1 to 280803c Compare September 1, 2023 13:12
@mvz mvz marked this pull request as ready for review September 1, 2023 13:12
- Update cucumber dependency to allow version 9.0
- Add appraisal to test with cucumber 9.0
- Add cucumber 9.0 to the CI matrix
@mvz mvz merged commit aa8a092 into main Sep 1, 2023
20 checks passed
@mvz mvz deleted the support-cucumber-9 branch September 1, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant