Clean up hook methods #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
clean-up-hook-methods
branch
from
e6bc684
to
d9e62cc
Compare
- Use separate methods for defining and running hooks - Remove unused methods for checking if hooks are defined
mvz
force-pushed
the
clean-up-hook-methods
branch
from
d9e62cc
to
40c36ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clean up hook methods
Details
Motivation and Context
Makes the hook methods more robust by making them require the arguments
needed for the narrower context in which each of them is used.
Simplifies the code in the hook methods by having to deal with fewer
cases.
How Has This Been Tested?
Running the tests.
Types of changes