Even more RuboCop cleanups #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
even-more-rubocop-cleanups
branch
from
3b5ffc9
to
975a2c1
Compare
|
If Travis continues to be difficult, should we investigate alternate CI solutions? |
Yes, that may be necessary. |
|
The current failure though, seems to have an ordinary reason: "can not find method |
No, that's a pending test, fortunately. Still, it's a distracting message that should be cleaned up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Process some to-dos from the RuboCop to-do file, and shorten the maximum line length.
Details
Motivation and Context
Working toward a cleanly formatted code base.
How Has This Been Tested?
Travis, although it seems to be having some issues lately.
Types of changes