Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several cuke improvements #703

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Several cuke improvements #703

merged 3 commits into from
Jan 31, 2020

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jan 30, 2020 •
edited
Loading

Summary

Several improvements to cucumber scenarios

Details

  • Fix a spelling error
  • Add extra scenarios to confirm output from multiple commands is checked the same way as in 0.14.x. These were taken from the 0-14-stable branch
  • Improve wording of cukes home_directory to match with what's really going on

Motivation and Context

The big part is confirming no change in output handling w.r.t. 0.14.x.

How Has This Been Tested?

Scenarios were run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

olleolleolle
olleolleolle approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mvz mvz merged commit 2abe6c7 into master Jan 31, 2020
@mvz mvz deleted the several-cuke-improvements branch January 31, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @olleolleolle