Find relative commands from the current Aruba directory #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an Arabu spec or scenario, files are created relative to the current Aruba directory. When creating an executable in that way, it should be possible to run that executable using the same relative path. This change means that executables in the project under test can no longer be find using the relative path from the project directory. They should be added to the path. This is done automatically by Bundler.
| #!/bin/bash | ||
| exit 0 | ||
| BASH | ||
| chmod 0x755, 'bin/aruba-test-cli' |
There was a problem hiding this comment.
This says 0x755 where the other one says 0o755, is there a difference by choice? Or by accident?
There was a problem hiding this comment.
Seems to be a RuboCop correction. I'll equalize these.
There was a problem hiding this comment.
Nope, it was just wrong 🙂. It should be 0o755 or 0755.
|
Yay hooray! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Find relative commands from the current Aruba directory
Details
In an Arabu spec or scenario, files are created relative to the current Aruba directory. When creating an executable in that way, it should be possible to run that executable using the same relative path.
This change means that executables in the project under test can no longer be find using the relative path from the project directory. They should be added to the path. This is done automatically by Bundler.
Technically this is accomplished by doing the command lookup inside an
in_current_directoryblock.Motivation and Context
Fixes #552.
How Has This Been Tested?
Specs and cukes were added.
Types of changes
Checklist: