Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development dependencies #701

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Update development dependencies #701

merged 2 commits into from
Jan 24, 2020

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jan 23, 2020

Summary

Update dependencies to their latest version

Details

Updates license finder and rubocop. Adjust license finder configuration because the whitelist option was changed to permit.

Motivation and Context

Keeps things up-to-date.

How Has This Been Tested?

Travis will tell.

With version 6, license_finder has changed the 'whitelist' option to
'permit'.
@olleolleolle
Copy link
Contributor

Scenario: Sending signal to the command started last

That scenario, on macOS, kind of flails a little

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping up-to-date with these changes.

@mvz
Copy link
Contributor Author

mvz commented Jan 24, 2020

# Scenario: Sending signal to the command started last

That scenario, on macOS, kind of flails a little

Yes, it's very annoying and hard to debug. We need someone with a MacOS system to debug it, if they can reproduce it.

@mvz mvz merged commit 49ed3be into master Jan 24, 2020
@mvz mvz deleted the update-dependencies branch January 24, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants