Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis.yml lint task #689

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Fix travis.yml lint task #689

merged 1 commit into from
Jan 2, 2020

Conversation

deivid-rodriguez
Copy link
Member

Summary

The previous library being used seems abandoned and not really working.

Details

Before:

$ bundle exec rake lint:travis
Linting .travis.yml ... No output is good!
.travis.yml: unexpected key "jobs", dropping

After:

$ bundle exec rake lint:travis
Linting .travis.yml ...
travis lint
Hooray, .travis.yml looks valid :)

The previous library being used seems abandoned and not really working.

Before:

```console
$ bundle exec rake lint:travis
Linting .travis.yml ... No output is good!
.travis.yml: unexpected key "jobs", dropping
```

After:

```console
$ bundle exec rake lint:travis
Linting .travis.yml ...
travis lint
Hooray, .travis.yml looks valid :)
```
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping an eye out!

@mvz mvz merged commit 35aa647 into master Jan 2, 2020
@mvz
Copy link
Contributor

mvz commented Jan 2, 2020

This has been bugging me for ages. Thanks for cleaning it up, @deivid-rodriguez!

@mvz mvz deleted the fix_travis_lint branch January 2, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants