Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cucumber deprecations #688

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Fix cucumber deprecations #688

merged 1 commit into from
Jan 2, 2020

Conversation

deivid-rodriguez
Copy link
Member

Summary

This PR fixes several cucumber deprecations.

Details

In particular,

Deprecated: Found tags option '~@unsupported-on'. Support for '~@tag' will be removed from the next release of Cucumber. Please use 'not @tag' instead.
Deprecated: Found tags option '~@wip'. Support for '~@tag' will be removed from the next release of Cucumber. Please use 'not @tag' instead.
Deprecated: Found tags option '~@ignore'. Support for '~@tag' will be removed from the next release of Cucumber. Please use 'not @tag' instead.

Motivation and Context

Warnings are annoying and can get things broken in the future.

How Has This Been Tested?

Running aruba's tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

In particular,

```
Deprecated: Found tags option '~@unsupported-on'. Support for '~@tag' will be removed from the next release of Cucumber. Please use 'not @tag' instead.
Deprecated: Found tags option '~@wip'. Support for '~@tag' will be removed from the next release of Cucumber. Please use 'not @tag' instead.
Deprecated: Found tags option '~@ignore'. Support for '~@tag' will be removed from the next release of Cucumber. Please use 'not @tag' instead.
```
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the quoting in place, and the CI green, this looks like it works better.

Thanks!

@mvz mvz merged commit b38d173 into master Jan 2, 2020
@mvz
Copy link
Contributor

mvz commented Jan 2, 2020

Thanks, @deivid-rodriguez!

@mvz mvz deleted the fix_cucumber_deprecations branch January 2, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants