Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ruby 2.7 (0.14.x version) #677

Merged
merged 4 commits into from
Dec 28, 2019
Merged

Support Ruby 2.7 (0.14.x version) #677

merged 4 commits into from
Dec 28, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Dec 28, 2019 •
edited
Loading

Summary

Silence warnings and make build pass on Ruby 2.7

Details

  • Pass keyword arguments to FileUtils methods explicitly.
  • Change console history scenario to test setting instead of result. The history was never actually saved in the scenario because under childprocess IRB doesn't activate an input reader that has a history. Ruby 2.7 won't even create the empty file so we need to check the configuration directly.

Motivation and Context

Ruby 2.7 is out and the warnings are annoying for Aruba's users.

How Has This Been Tested?

Specs and cukes were run under Ruby 2.7

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz
Silence keyword argument warnings on Ruby 2.7
6ef7ea6
@mvz
Clarify method parameter names
c37c40a
@mvz
Update scenario to pass on Ruby 2.7
d007616 
When running under childprocess, IRB does not activate readline. This
means history is not collected and the history file is empty if saved.
In Ruby 2.7, the file is not even written to. This means saving the
history file cannot properly be tested on Ruby 2.7 using Aruba. Instead,
we check that the correct file is configured in IRB, and just assume IRB
will do the right thing with it.
@mvz
Run tests on Ruby 2.7
e2789e1
@mvz mvz changed the title Support ruby 2.7 (0.14.x version) Support Ruby 2.7 (0.14.x version) Dec 28, 2019
olleolleolle
olleolleolle approved these changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improved names make this fix an enhancement.

@mvz mvz merged commit 2dd01d6 into still Dec 28, 2019
@mvz mvz deleted the support-ruby-2-7-still branch December 28, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvz @olleolleolle