Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both 'a' and 'the' in step, as documented #660

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jul 20, 2019

Summary

Allow both 'a' and 'the' in file mode checking step, as documented in the corresponding feature file.

Details

Updates the step regexp to allow both 'a' and 'the' at the start. So, now 'a file named ...' is properly matched.

Motivation and Context

Oddly, on JRuby 9.2.7.0, cucumber fails on undefined steps. This made the feature for this step fail and surfaced the problem.

How Has This Been Tested?

Nothing yet. We need to have some way to detect undefined steps better.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@mvz mvz merged commit dde7364 into master Jul 25, 2019
@mvz mvz deleted the fix-step-definition branch July 25, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants