Do not set binmode on output temp files #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes binmode so Ruby can do its automatic line ending conversion like it used to. To avoid encoding compatibilities, the encoding on the temp files is set to 8 bit ascii.
mvz
force-pushed
the
issue-614-no-binmode-still
branch
from
905f9c4
to
96c68ba
Compare
mvz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Let Ruby handle line ending conversion, making use of Aruba easier for Windows users
Details
SpawnProcess used to set binmode on the tempfiles used to capture stdout and stderr. This was done to fix failures on JRuby. This is removed to allow line endings to be handled automatically. The JRuby failures are fixed by setting the encoding on the tempfiles instead.
Motivation and Context
This fixes #614.
How Has This Been Tested?
Basically, by running the test suite on Travis. The original change to binmode was badly tested as well.
Types of changes
Checklist: