Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore previously removed behaviors #644

Merged
merged 6 commits into from
Jun 11, 2019
Merged

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jun 10, 2019

Summary

Restore behaviors in master whose deprecation in 0.1.4.x was reverted.

Details

  • Restore the API methods #in_current_directory, #all_stdout, #all_stderr, #all_output.
  • Raise an error in output matchers when actual object does not respond to required methods. Previously, the matcher would just fail.
  • Restore old behavior for output-matching cucumber steps, splitting them up a bit as well.

Motivation and Context

Fixes #641.

How Has This Been Tested?

Tests in 0.14.x for #in_current_directory were copied as well. The other methods are only tested through the cucumber scenarios at the moment.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz mvz mentioned this pull request Jun 10, 2019
1 task
@mvz mvz force-pushed the issue-641-restore-behaviors branch from 0c564f2 to f2eddf1 Compare June 10, 2019 18:46
@mvz mvz force-pushed the issue-641-restore-behaviors branch from f2eddf1 to 3522167 Compare June 10, 2019 19:24
@mvz mvz merged commit 5feab34 into master Jun 11, 2019
@mvz mvz deleted the issue-641-restore-behaviors branch June 11, 2019 04:57
@mvz mvz mentioned this pull request Dec 7, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore selected old behaviors
1 participant