-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeprecate some stuff #638
Conversation
These turn out to be very useful and their replacement is unwieldy.
See #605. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a couple of my changes are easy to make, and a couple I could be wrong with.
All in all this is tricky to review, so I've not spent too long on it. The problem with some of these cukes is getting almost untenable and we definitely should refactor some of them for 1.0 / 0.14.x
Also is this branch being merged into master in some guise so these commands will still exist in 1.0?
features/03_testing_frameworks/cucumber/steps/command/check_output_of_command.feature
Outdated
Show resolved
Hide resolved
Yes, I will make another pull request to re-introduce these in master. |
@luke-hill I updated the scenario wording and will defer further clean-up of the cucumber steps to later. |
Summary
Restores
#all_output
,#all_stdout
,#all_stderr
and#in_current_directory
API methods to non-deprecated status. Also un-deprecates the current behavior of output-checking cucumber steps.Motivation and Context
How Has This Been Tested?
Some tests were added but mostly code was just moved.
Types of changes
Checklist: