Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeprecate some stuff #638

Merged
merged 7 commits into from
May 31, 2019
Merged

Undeprecate some stuff #638

merged 7 commits into from
May 31, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented May 31, 2019

Summary

Restores #all_output, #all_stdout, #all_stderr and #in_current_directory API methods to non-deprecated status. Also un-deprecates the current behavior of output-checking cucumber steps.

Motivation and Context

  • These API methods seem to be the deprecated methods most used by downstream projects, and their replacements are more complex.
  • The output-checking cucumber steps are currently set to have a breaking change in 1.0.0 and we should instead have a smooth upgrade path that will allow moving from latest 0.14.x to 1.0.0 when the latter is released.
  • The replacement cucumber steps in master currently have less useful output, and the current behavior is more intuitive.

How Has This Been Tested?

Some tests were added but mostly code was just moved.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added (some) tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz
Copy link
Contributor Author

mvz commented May 31, 2019

See #605.

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple of my changes are easy to make, and a couple I could be wrong with.

All in all this is tricky to review, so I've not spent too long on it. The problem with some of these cukes is getting almost untenable and we definitely should refactor some of them for 1.0 / 0.14.x

Also is this branch being merged into master in some guise so these commands will still exist in 1.0?

lib/aruba/api/deprecated.rb Show resolved Hide resolved
lib/aruba/cucumber/command.rb Show resolved Hide resolved
lib/aruba/api/deprecated.rb Show resolved Hide resolved
@mvz
Copy link
Contributor Author

mvz commented May 31, 2019

Also is this branch being merged into master in some guise so these commands will still exist in 1.0?

Yes, I will make another pull request to re-introduce these in master.

@mvz
Copy link
Contributor Author

mvz commented May 31, 2019

@luke-hill I updated the scenario wording and will defer further clean-up of the cucumber steps to later.

@mvz mvz mentioned this pull request May 31, 2019
@mvz mvz merged commit 1b37205 into still May 31, 2019
@mvz mvz deleted the undeprecate-some-stuff branch May 31, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants