Fix JRuby builds #637
Merged
Fix JRuby builds #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😞 😿 |
mvz
force-pushed
the
fix-jruby-builds
branch
2 times, most recently
from
34a12af
to
43914b1
Compare
Coverage is inaccurate unless running in debug mode
The Fuubar formatter will continue outputting even when a spec is on-hold in a debugger like pry. Use the default formatter instead to avoid this annoyance.
There's an issue with dup-ing an exception after its backtrace has been set manually in JRuby 9.2.7.0. It should be resolved in 9.2.8.0 once that's released. See jruby/jruby#5738 for more details.
Linux Travis workers use an older version of Java that doesn't understand the --add-opens flag.
The original timeout value (5) was sometimes too small to allow the process to finish on Travis CI. A value of 30 should allow enough time. In general, the process will end much more quickly.
The cucumber scenarios take way too long at the moment. Disable those for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JRuby builds have been failing on master for a while. Make them pass.
Details
Note: Some parts of this pull request have been forward-ported from
still.aruba/config/jrubyhelper to set JRuby optionscucumber.ymlwhich contained outdated assumptions about theRUBY_DESCRIPTIONconstant.Motivation and Context
If we want to support JRuby, builds should be green and build failures should be blocking for pull requests.
How Has This Been Tested?
Repeated running of the tests on Travis until everything passed.
Types of changes