New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeoutError is deprecated in favor of Timeout::Error #628

Merged

olleolleolle merged 1 commit into cucumber:master from amatsuda:TimeoutError

May 21, 2019

Member

amatsuda commented May 20, 2019

Ruby stdlib Timeout's TimeoutError is deprecated in favor of Timeout::Error.

https://github.com/ruby/ruby/blob/34d7ec4e9b0a24b3ce89009927738f1dac38e6d3/lib/timeout.rb#L125-L130


          TimeoutError is deprecated in favor of Timeout::Error

9f864b3

Member Author

amatsuda commented May 20, 2019

I mean, even in the oldest supported Ruby, 2.2.0 https://github.com/ruby/ruby/blob/v2_2_0/lib/timeout.rb#L128-L130

olleolleolle approved these changes

View reviewed changes

Contributor

olleolleolle left a comment

Let's get this merged!

🎉

olleolleolle merged commit 1ef8f46 into cucumber:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet