Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move deprecated cucumber steps into a separate file #622

Merged
merged 1 commit into from
May 22, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented May 20, 2019

Summary

Move deprecated cucumber steps into a separate file

Details

Move deprecated cucumber steps into lib/aruba/cucumber/deprecated.rb.

Motivation and Context

Part of #598. This will make merging easier.

How Has This Been Tested?

Travis.

Types of changes

  • Refactoring (cleanup of codebase without changing any existing functionality)

@mvz mvz mentioned this pull request May 20, 2019
12 tasks
@mvz mvz force-pushed the move-deprecated-cuke-steps branch from f64047d to 9515a8c Compare May 20, 2019 17:50
@mvz mvz merged commit b1e9324 into still May 22, 2019
@mvz mvz deleted the move-deprecated-cuke-steps branch May 22, 2019 08:31
@luke-hill
Copy link
Contributor

@mvz are these deprecated slated for v1 removal or somewhere further than that? Just wondering if it's worth merging this into master as well.

@mvz
Copy link
Contributor Author

mvz commented May 22, 2019

@luke-hill yes, these will be removed in v1 and are in fact already gone from master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants