Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Ruby 2.2 support #616

Merged
merged 12 commits into from
May 23, 2019
Merged

Drop Ruby 2.2 support #616

merged 12 commits into from
May 23, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented May 18, 2019

Summary

Drop support for Rubies older than 2.3

Details

  • Bump required Ruby version
  • Bump RuboCop target ruby version
  • Update RuboCop since latest version supports Ruby 2.3 and up
  • Fix new RuboCop offenses
  • Remove outdated version checks

Motivation and Context

This simplifies future maintenance by limiting set of supported Ruby versions. Dropping support for 2.3 before the final release is a distinct possibility. Projects that need support for older Rubies can stick with Aruby 0.x until they're ready.

How Has This Been Tested?

Travis will tell ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz
Copy link
Contributor Author

mvz commented May 18, 2019

After this, I think we can release 1.0.0.alpha3.

@mvz
Copy link
Contributor Author

mvz commented May 18, 2019

I'm going to need to fix issues due to the frozen string comments.

@mvz mvz requested review from luke-hill and removed request for luke-hill May 20, 2019 08:30
@mvz
Copy link
Contributor Author

mvz commented May 20, 2019

@luke-hill I'm going to release alpha3 first.

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you if you want to do a quick-fix for the one versioned gem.

Gemfile Outdated Show resolved Hide resolved
@luke-hill
Copy link
Contributor

I've made the minor fixes @mvz just to try help you out. If CI passes I'll merge it in and crack on with some more auto-tidy stuff in the master branch.

@mvz
Copy link
Contributor Author

mvz commented May 23, 2019

Thanks @luke-hill. Merge at will! 😄

@luke-hill luke-hill merged commit 813e229 into master May 23, 2019
@luke-hill luke-hill deleted the drop-ruby-2-2-support branch May 23, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants