Unify feature file organization #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-hill
reviewed
Apr 23, 2019
| Feature: Check | ||
| Scenario: Check | ||
| Given a file named "foo" with: | ||
| \"\"\" |
There was a problem hiding this comment.
Are these escaped because were inside a """ already? I don't use aruba really.
There was a problem hiding this comment.
Yes, that is the reason. It's a little ugly 😞.
| @@ -3,6 +3,63 @@ Feature: Check file content | |||
| Background: | |||
| Given I use a fixture named "cli-app" | |||
|
|
|||
| Scenario: Check file contents with plain text | |||
| Given a file named "features/non-existence.feature" with: | |||
There was a problem hiding this comment.
why is this file called non-existence?
There was a problem hiding this comment.
Not sure. I copied this feature from master I think.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-organize feature files to match master
Details
Files were moved and minimal changes to their contents were done to get rid of some custom steps. Some less-useful feature files were removed.
Motivation and Context
Part of #598.
How Has This Been Tested?
N/A. Functionality should stay the same.
Types of changes