Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deprecation messages #601

Merged
merged 4 commits into from
Mar 13, 2019
Merged

Improve deprecation messages #601

merged 4 commits into from
Mar 13, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Mar 13, 2019

Summary

Improve recommendation messages

Details

  • Attempt to recommend only non-deprecated alternatives
  • Fix broken recommendations
  • Wrap long lines to have overview of recommendations
  • Warn about all methods in Deprecated module

Motivation and Context

Fixes #576.

Types of changes

  • Update documentation

mvz added 4 commits March 13, 2019 13:13
- Attempt to recommend only non-deprecated alternatives
- Fix broken recommendations
- Wrap long lines to have overview of recommendations
- Warn about all methods in Deprecated module
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mvz mvz merged commit fc833a7 into still Mar 13, 2019
@mvz mvz deleted the issue-576-output-all-commands branch March 13, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants