-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cucumber steps to use have_same_file_content_as
matcher
#572
Fix Cucumber steps to use have_same_file_content_as
matcher
#572
Conversation
History.md
Outdated
@@ -1,3 +1,7 @@ | |||
# UNRELEASED | |||
|
|||
* Fix Cucumber steps to use `have_same_file_content_as` matcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add (#572)
at the end of this line? That'd harmonize it with the other entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Now I get my number 😄 Amended into the last commit 9146d2d
2ac79de
to
9146d2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kinopyo!
I'll merge once Travis has finished ... |
@mvz CI puts us off 😅 gentle ping... 🙏 |
Hi @kinopyo, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
@aslakhellesoy wow! Thanks for the kind offer! Will check out those links and hopefully can contribute more! 💪 Cheers 🍻 |
※ Pointing to
still
branchSummary
Follow up on #557: update the cucumber step to use the new matcher
have_same_file_content_as
.Details
Confirmed in #557 (comment) that we missed to update the cucumber part to use the newly updated matcher.
How Has This Been Tested?
Don't think there's any existing tests that I can work on...? 🤔
And I know this is not scientific at all, I happen to update the gem for a project, and was able to use my patch to correctly compare the file content.
Also did a grep and confirmed all references of the now-deprecated matcher
have_same_file_content_like
are updated.Types of changes
Checklist:
I updated the
History.md
file to jot down the change, feel free to modify it to your needs. 🙂cc @mvz @xtrasimplicity