Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cucumber steps to use have_same_file_content_as matcher #572

Conversation

kinopyo
Copy link

@kinopyo kinopyo commented Aug 28, 2018

※ Pointing to still branch

Summary

Follow up on #557: update the cucumber step to use the new matcher have_same_file_content_as.

Details

Confirmed in #557 (comment) that we missed to update the cucumber part to use the newly updated matcher.

How Has This Been Tested?

Don't think there's any existing tests that I can work on...? 🤔

And I know this is not scientific at all, I happen to update the gem for a project, and was able to use my patch to correctly compare the file content.

Also did a grep and confirmed all references of the now-deprecated matcher have_same_file_content_like are updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I updated the History.md file to jot down the change, feel free to modify it to your needs. 🙂

cc @mvz @xtrasimplicity

History.md Outdated
@@ -1,3 +1,7 @@
# UNRELEASED

* Fix Cucumber steps to use `have_same_file_content_as` matcher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add (#572) at the end of this line? That'd harmonize it with the other entries.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Now I get my number 😄 Amended into the last commit 9146d2d

@kinopyo kinopyo force-pushed the fix/use-recommended-matcher-in-cucumber-file branch from 2ac79de to 9146d2d Compare August 28, 2018 08:16
Copy link
Contributor

@mvz mvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kinopyo!

@mvz
Copy link
Contributor

mvz commented Aug 28, 2018

I'll merge once Travis has finished ...

@kinopyo
Copy link
Author

kinopyo commented Aug 31, 2018

@mvz CI puts us off 😅 gentle ping... 🙏

@xtrasimplicity xtrasimplicity merged commit 4004e33 into cucumber:still Aug 31, 2018
@aslakhellesoy
Copy link
Contributor

Hi @kinopyo,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@kinopyo
Copy link
Author

kinopyo commented Aug 31, 2018

@aslakhellesoy wow! Thanks for the kind offer! Will check out those links and hopefully can contribute more! 💪

Cheers 🍻

@kinopyo kinopyo deleted the fix/use-recommended-matcher-in-cucumber-file branch August 31, 2018 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants