Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen dependency on childprocess #553

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Loosen dependency on childprocess #553

merged 1 commit into from
Mar 16, 2018

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Mar 16, 2018

Summary

Like it says on the tin.

Details

Allows all versions of childprocess that we can reasonable expect to work with aruba according to the childprocess changelog

Motivation and Context

Allows latest childprocess to be used with Aruba (like already is the case for 0.14.x).

How Has This Been Tested?

We're currently lacking tests for checking if the lowest required versions for dependencies still work. Other than that: Travis.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@enkessler
Copy link

FYI: childprocess is semantically versioned (or at least has been since I've been maintaining it), so you should be safe all the way until 1.0.0.

@mvz mvz merged commit 153ecdb into master Mar 16, 2018
@mvz mvz deleted the update-childprocess branch March 16, 2018 19:18
@mvz
Copy link
Contributor Author

mvz commented Mar 16, 2018

@enkessler good to know. I'll take that into account in the next dependency update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants