Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use known-good osx_image for old Rubies #536

Merged
merged 1 commit into from
Feb 4, 2018
Merged

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Feb 3, 2018

Summary

Fix the build for Ruby 2.0.0 and 1.9.3 on OSX.

Details

Ruby 2.0.0 and 1.9.3 cannot be installed on the default Travis CI OS X images. Use the xcode8 image instead, which uses OS X version 10.11 and Xcode version 8gm.

Motivation and Context

These builds were ignored and continuously failing, almost at the start of the build, making them effectively useless.

How Has This Been Tested?

These settings yielded succesful builds in the experimental pull request #534.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Ruby 2.0.0 and 1.9.3 cannot be installed on the default Travis CI OS X
images. Use the xcode8 image instead, which uses OS X version 10.11
and Xcode version 8gm.
@olleolleolle
Copy link
Contributor

Lgtm!

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@mvz mvz merged commit 652d863 into master Feb 4, 2018
@mvz mvz deleted the fix-osx-builds-for-old-rubies branch February 4, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants