Fix @no-clobber behavior #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@no-clobber does not call Setup#call *at all*, which causes the process monitor to not be listening to process events
olleolleolle
reviewed
Feb 2, 2018
lib/aruba/api/core.rb
Outdated
| def setup_aruba | ||
| Aruba::Setup.new(aruba).call | ||
| def setup_aruba(clobber: true) | ||
| Aruba::Setup.new(aruba).call(clobber: clobber) |
There was a problem hiding this comment.
This syntax is the incompatible one.
There was a problem hiding this comment.
Yes, but it should be fine on master since we dropped support for 1.8.
There was a problem hiding this comment.
Ah bummer, I forgot this won't work with 1.9 either 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure setup is run even if files are not clobbered.
Details
See #529.
Motivation and Context
Fixes #527.
How Has This Been Tested?
Scenarios were updated to demonstrate that setup is also run when
@no-clobberis set, but files are not clobbered.Types of changes
Checklist: