Update 0.14 - dependencies and build failure fixes #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvz This is work in progress? |
|
@maxmeyer yes, definitely :-) |
mvz
force-pushed
the
update-dependencies-still
branch
from
a099eba
to
bd4e16f
Compare
This feature runs specs that are also run outside cucumber, possibly from a different branch. This is unnecessary duplication of work.
This feature also does an expensive clone of the aruba repository. In addition, steps should be documented in a nice format. We should not require users to clone our repo for this.
mvz
force-pushed
the
update-dependencies-still
branch
from
ae4d433
to
c256e38
Compare
- Run specific JRuby version - Make sure output stays within Travis' limits
These features fail on Travis due to some extra output by Java: Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m
mvz
force-pushed
the
update-dependencies-still
branch
from
2001e76
to
dda2c55
Compare
This avoids test failures on JRuby due to encoding issues in childprocess.
| @@ -92,7 +95,7 @@ def start | |||
| end | |||
| # rubocop:disable Metrics/MethodLength | |||
|
|
|||
| # Access to stdout of process | |||
| # Access to stdin of process | |||
|
@mvz Ok. I flagged this as work in progress. |
|
Wow, that looks like a big amout of work. Thanks that you work on this one! |
mvz
changed the title
|
This is ready for review. |
|
LGTM. Merged. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update childprocess dependency and fix build failures for the 0.14 series
Details
Motivation and Context
It's annoying that the released version of Aruba pulls in an outdated runtime dependency. Since 1.0.0 will take a little while to finish, it's good to keep 0.14.x in shape. Also, there were some build failures so these have been fixed as well.
How Has This Been Tested?
Travis 🙂
Types of changes