Update rubocop #514
Update rubocop #514
Conversation
|
I wonder, did you ever see |
No, but it looks really useful. |
|
Unfortunately, RuboCop 0.51 requires Ruby >= 2.1, so we can either:
|
|
Can you use (Does 0.51.0 even support |
This will allow rubocop to regenerate exclusions when needed.
|
It turns out |
|
@mvz Thank you for going the distance with this issue. |
|
@mvz To back up my "why don't you just" about RuboCop: Here's a Travis configuration, which uses the built-in, implicit 'test' Stage, and adds a 'codestyle' stage. https://github.com/egonSchiele/contracts.ruby/blob/master/.travis.yml |
|
Right, so rubocop 0.50 also doesn't install on 1.9.3. @olleolleolle I'll go with your suggestion. |
|
@mvz I might be that you must decide on |
|
I'll actually read the docs, now ;-) |
|
@mvz Is this still work in progress? |
|
@maxmeyer yes, I need to get the separate Travis build for RuboCop working. |
| @@ -6,10 +6,13 @@ require 'aruba/platform' | |||
| require 'bundler' | |||
| Bundler.setup | |||
|
|
|||
| task :default => :test | |||
| task default: [:lint, :test] | |||
There was a problem hiding this comment.
Do we need both here?
Rakefile
Outdated
| desc 'Run the whole test suite. Any failure will stop rake going on' | ||
| task :test => %w(lint:travis lint:coding_guidelines lint:licenses test:rspec test:cucumber test:cucumber_wip) | ||
| desc 'Run all linters.' | ||
| task test: %w(lint:travis lint:coding_guidelines lint:licenses) |
There was a problem hiding this comment.
Ah, sorry: this is labeled wrong: task lint: ... it should be!
|
@mvz I followed some error messages, and found a typo. |
|
The Travis build was fixed. |
Summary
Update RuboCop to 0.50.0
Details
.rubocop_todo.ymlto allow auto-generation.Motivation and Context
Follow-up of #511.
Types of changes